Gmaps not loaded with async

Created on 22 February 2024, 4 months ago

Updated 8 March 2024, 4 months ago

Being this isn't technically a bug I've opened this issue as a feature request.

Each time a gmap loads via geofield_map browser console gives warning saying the maps API should be loaded using async.

So here is a patch that adds async when gmaps api is used. Super simple just added + '&loading=async' to the scriptPath in geofield_map_gmap_formatter.js and geofield_map_widget.js making this
scriptPath += '&key=' + gmap_api_key + '&loading=async';

As near as I can tell this doesn't break anything...

✨ Feature request

Status

Fixed

Version

3.0

Component

Code

Created by

🇺🇸United States sidgrafix

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @sidgrafix
Comment 4 months ago →
🇺🇸United States sidgrafix
Comment 4 months ago →
System Message

itamair → committed cfecc445 on 3.0.x authored by sidgrafix →
Issue #3423274 by sidgrafix: Gmaps not loaded with async
Status changed to Fixed 4 months ago5:34pm 23 February 2024
Comment 4 months ago →
🇮🇹Italy itamair
Thanks @sidgrafix ... nice catch and fix.
I slightly changed it, but committed still crediting it to you.
This fix will be part of next Geofield Map module release ...
Comment 4 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024