Display the product variation title in the variations list if not configured to generate titles automatically.

Nevermind on this, go ahead and close it if you like.. I'm doubtful this is a bug (but could be, I have no idea what the default behavior for this should be - it's not documented)

Finally, I figured out where the actual values come from that appear in the dropdown that is listed as "Title" in a products variation next to SKU in the displayed variations table of a product; pulls from commerce/product-attributes the attribute that was initially created meaning if an attribute is used and selected in the product variation it will use it's value as the title, otherwise it is what is expected and is the title of the variation itself. (so maybe bug or maybe not, default behavior escapes me)

If it is the default behavior I think listing it as "Title" in the "Add variation" edit/tab the way it is, is extremely confusing! I would assume being when a products variation is added "as on creation it has a title field you have to fill out" that would be the "Title" listed next to the "SKU" in the table of variations for a product.

To make such things less confusing I think some kind of helper that can indicate that the title there is not the title created for/in the products variation (as in it will not be the title you will see when you click on edit for a given variation when an attribute is used in the variation) as it is pulled from the "value" selected in the attribute (in my case initially created as a "Product attribute") which was then added as a field to the product variation type. Maybe simply putting titles that are not the variations title in brackets like (Monthly Recurring) with a key above the products variation tabe showing any title in () is the selected attribute value, or something along those lines with perhaps a little documentation explaining why this is like this. (unless this is a bug?)

In general it's confusing enough having to create all the different aspects used in a product (outside of the product) to then use with and in a product, or product group, as well as any corresponding store attributes to then be limited by product variations are per product only. It honestly everything feels like it is all created/setup independently then nested upon nested with this includes that and that includes something else which in turn includes something else just to get it all to work together with very little documentation explaining things.
- sorry, if any of that sounds harsh I apologize (i'm just a bit frustrated, the lack of documentation and explainations for things with commerce core) has me on edge being this is one of the last few things I need to get working properly on a Drupal 10 site replacing a Drupal 7 site..

Sorry for closing this.
Indeed I understand the behavior can be confusing...

TBH, I'm also wondering why the following logic is in place for displaying the title in this table:

if ($attribute_values = $entity->getAttributeValues()) {
      // The generated variation title includes the product title, which isn't
      // relevant in this context, the user only needs to see the attributes.
      $attribute_labels = EntityHelper::extractLabels($attribute_values);
      $title = implode(', ', $attribute_labels);
    }
    else {
      $title = $entity->label();
    }

I believe we should check here the variation type settings... Basically, same as the logic that runs on product variation presave:

if ($variation_type->shouldGenerateTitle()) {
      $title = $this->generateTitle();
      $this->setTitle($title);
    }

So in other words, if the product variation type is configured to generate titles based on attribute values, we should check the attribute values, otherwise fallback to the product variation title...

So what about the attached patch? Does it solve the issue you're describing? Sorry for the late followup btw.

Actually... Since the titles should be updated on presave, we should probably only display the title here... And we shouldn't have to generate the title on the fly...

hm... I'm not sure about this change anymore, yeah it looks like this was done on purpose to not output the product title, based on the following comment:

      // The generated variation title includes the product title, which isn't
      // relevant in this context, the user only needs to see the attributes.

Also, in any case the list could be replaced by a view, the reason why it's not a view by default is because of the draggable rows to allow reordering the variations.

Need to think about this a little more...

@sidgrafix: DId you initially set up attributes and finally ended up not using them but existing variations already have attribute values set?

Decided to go ahead with the patch. If no configured to automatically generate titles, we should just output the variation title.

@jsacksick regarding your question in #8 - at this point I'm not entirely sure. After I got the products sorted regarding the title on variations as to what was coming from where (at that point still frustrated all a around with commerce) I moved on to other areas of the site that needed to be done yet (which is still in progress) and haven't been back to deal with commerce since.

I think/may have (honestly can't remember exactly), initially intended to use variations as purchase options used with recurring payments, but inevitably ended up using product attributes to handle that with the variations created in each product. It still doesn't make much sense to me the way it all works (having to have product variation types - that aren't an actual products variation(s) having to create actual variations in the product itself but have to use a product variation type, but while creating the actual variation linking in the attributes which in my case is handling the billing options...

- More so confusing that the products variation title uses the attributes option as the title and not the actual variation title. I do also think before I really dove into all that, at one point just testing to see what does what I may have (again not entirely sure) checked the option to generate variation titles based on attribute values to on, but then turned it off before I really got into setting things up and getting commerce products configured which may have complicated the entire ordeal. With that said I'm sure somewhere at some point don the line when I get back to it I probably have done something wrong or took steps in the wrong order when setting that all up and will have to redo some things as "my luck" tends to go. Especially being the original still active site using Drupal 7 uses ubercart and the new version started in Drupal 9 now 10 still in development is now using commerce.

And no, I have not tried this patch - but surely will when I get back to commerce. I did try some of the other patches at the time that seemed like they could be related, but none produced the results I was looking for.

In all "thank you" for giving this some attention, anything added that works towards making things less confusing is a plus in my book!

Automatically closed - issue fixed for 2 weeks with no activity.