Contrib.social

commerce_dashboard_show_toolbar_link does not affect the local action link

Open on Drupal.org →
Created on 21 February 2024, over 1 year ago
Updated 27 May 2024, about 1 year ago

The recent addition of the Commerce dashboard adds two persistent "inbox" links back to the dashboard: one in the toolbar (labeled "[icon][count] Commerce inbox") and one as a local action, labeled "[icon] Commerce inbox ([count])". A settings variable to disable the toolbar link was added ("commerce_dashboard_show_toolbar_link"), but this doesn't affect the local actions link.

There are a few possible approaches here:

  1. Overload the definition of "toolbar" in "commerce_dashboard_show_toolbar_link" to mean "both the toolbar link and the local action link". That seems to make the most "usable" sense, since someone who wants to disable the toolbar link likely will _always_ want to disable the local action link too.
  2. Add separate user permissions to view these links. This would allow the configuration to be set on a per-role basis and via the UI. This, however, is an entirely different feature - it would be impossible for user ID 1 to ever NOT see the links.
  3. Replace "commerce_dashboard_show_toolbar_link" with "commerce_dashboard_show_inbox_links". This is future proof cos then we could spam the inbox link wherever we want, and it'd all be covered by one setting (see also "commerce_show_partner_banners"). However, folks are already using "commerce_dashboard_show_toolbar_link" and we don't want to worry about upgrade paths or rework.

After discussion with jsacksick and rszrama in Slack, they're leaning toward Option 1.

✨ Feature request
Status

Fixed

Version

2.0

Component

User experience

Created by

🇺🇸United States morbus iff

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024