Add a config action to add entity types and bundles to a Content Moderation workflow

Honestly...on second thought, we might not need this to be generic at all. It's probably easier to just expose the plugin-specific actions we need, in the modules that provide them.

This blocks #3365143-8: [PP-2] Model core's Umami install profile as recipes → .

Beautiful! 😍 Zero remarks.

We're not running this test or scanning this code. See .recipes.gitlab-ci.yml - you need to add the directories to the TEST_DIRECTORIES and CODE_DIRECTORIES - also can you move the test into it's own directory in the content_moderation module so that it is separate.

Nice catch; fixed.

Since this was not a substantive code change, flipping this back to RTBC.

I'm wondering something... what happens if a recipe enables content_moderation and uses this plugin in the same recipe - will that work? How does recipe validation work when the action plugin does not exist yet?

Plus we need to convert this to an ConfigAction attribute now

Converted to an attribute!

Regarding #11, this is something we added test coverage for in #3423523: Test that recipe runner fails and rolls back if a recipe tries to use a non-existent config action → . The recipe runner will fail because the plugin does not exist.

That said, the plugin will exist the moment the providing module is installed by the recipe. I've changed the test to prove this; it now installs Content Moderation and Workflows, and creates the editorial workflow (copied from the Standard editorial_workflow recipe), before using the config action.

Just one review comment left

I've added the new plugin directory to the list of things to be scanned and there are some things to fix.

Come on, this is no fair.

PHPStan is giving me errors like this one, in AddModeration.php:

32     Method                                                                                
         Drupal\content_moderation\Plugin\ConfigAction\AddModeration::create()                 
         has parameter $configuration with no value type specified in iterable                 
         type array.                                                                           
         💡 See:                                                                               
            https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type  

This is in reference to a completely standard implementation of ContainerFactoryPluginInterface::create().

What exactly am I supposed to do here?? $configuration is unused, and the interface docs (which I can't change) just specify a type hint of array.

This feels like too many pointless hoops to jump through.

@phenaproxima it just goes in the baseline and we forget. I do this that we should comment on the level 9 for core issue to show how disruptive this will be for adding new work to core.

FWIW the phpstan level 9 job has a baseline for you to download with all the errors included - which you can download and commit and then the job will be green.

Fixed what I could, but altered the baseline as well to account for core's non-compliance. Finally we're passing!

Everything in the last couple of days was just coding standards-related; I don't think I made any substantive changes.

Committed and pushed b4fc09885e2 to 11.x and 20a2005e57e to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.