Pointless code: String return value from onbeforeunload

// Handle backbutton, exit etc. window.onbeforeunload = function() { // Add CKEditor support. if (typeof (CKEDITOR) != 'undefined' && typeof (CKEDITOR.instances) != 'undefined') { for (var i in CKEDITOR.instances) { if (CKEDITOR.instances[i].checkDirty()) { edit = true; break; } } } if (edit && !click) { click = false; return (Drupal.t("You will lose all unsaved work.")); } }

Comments & Activities

Issue created by @donquixote
Comment 9 months ago →
🇩🇪Germany donquixote
Btw mdn documents a different way of using this event:
https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event

Instead of a return value, they call event.preventDefault()
First commit to issue fork.
Assigned to himanshu_jhaloya
Comment 9 months ago →
🇮🇳India himanshu_jhaloya Indore
Merge request !3Pointless code issue fix → (Open) created by himanshu_jhaloya
Comment 9 months ago →
🇮🇳India himanshu_jhaloya Indore
Hi @donquixote, I have added the event.preventDefault() Instead of a return. Please Review the MR
Issue was unassigned.
Status changed to Needs review 9 months ago7:47am 20 February 2024
Comment 9 months ago →
🇮🇳India himanshu_jhaloya Indore
Status changed to Needs work 9 months ago12:16pm 20 February 2024
Comment 9 months ago →
🇩🇪Germany donquixote
Now we still return a string which has no effect.
Comment 9 months ago →
🇩🇪Germany donquixote
Actually, maybe the string return is not so useless after all?
It could depend on the browser.
I only tested with Brave so far.

@himanshu_jhaloya You did a number of pull requests following the proposals already in the issue, but sometimes the original proposal needs to be questioned.

Pointless code: String return value from onbeforeunload

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!3Pointless code: String return value from onbeforeunload
Open

Comments & Activities

Pointless code: String return value from onbeforeunload

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!3Pointless code: String return value from onbeforeunloadOpen

Comments & Activities

!3Pointless code: String return value from onbeforeunload
Open