This snippet in the js seems to have no effect:
// Catch all links and buttons EXCEPT for "#" links.
$("a, button, input[type='submit']:not(.node-edit-protection-processed), button[type='submit']:not(.node-edit-protection-processed)")
.each(function() {
$(this).click(function() {
// Return when a "#" link is clicked so as to skip the
// window.onbeforeunload function.
if (edit && $(this).attr("href") != "#") {
return 0;
}
});
});
To make a difference, it would have to return false instead of 0.
But it is also questionable whether this would be a good thing.
Delete the snippet, or let it return null or undefined instead of 0.
The behavior is still the same.
Remove the complete part.
Needs review
1.0
Code
Hi, @donquixote Followed the Steps to reproduce pass the value return null. created the MR. Please Review
Hello @himanshu_jhaloya
If the code section is indeed useless, we rather remove all of it.
The "return null" experiment was just to see what would happen.