Contrib.social

Allow for opting out of Tugboat Previews on core merge requests

Open on Drupal.org →
Created on 19 February 2024, about 1 year ago
Updated 18 June 2024, 10 months ago

Problem/Motivation

Currently all core merge requests will automatically create a Tugboat Preview. This may be unnecessary or undesirable for certain initiatives, and creating needless activity on the merge request.

Steps to reproduce

Proposed resolution

The idea proposed in slack is to check if the issue has a skip Tugboat label.

Remaining tasks

User interface changes

None.

API changes

The Tugboat integration will need to check the labels from the MR's associated issue, and conditionally create a preview if the skip Tugboat label is not present on the issue.

Data model changes

None.

✨ Feature request
Status

Active

Version

3.0

Component

GitLab integration

Created by

🇺🇸United States q0rban Atlanta, GA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @q0rban
  • Comment about 1 year ago →
    🇺🇸United States q0rban Atlanta, GA
  • Comment about 1 year ago →
    🇺🇸United States drumm NY, US

    This is all done in drupalorg code, adding another check in TugboatPreview::fromGitLabPayload()

    We could have it react to Drupal.org issue tag, or GitLab merge request label. I think we should use a MR label. When issues are on GitLab, the MR/issue relation is a bit looser, a MR could be associated with multiple issues, we don't want to think about figuring out that logic. Checking an MR label will be more straightforward. And it would be good to start getting some use of MR labels.

  • Comment 10 months ago →
    🇦🇺Australia mstrelan

    IMHO Tugboat should be opt-in rather than out. Can't help but think of the wasted resources running it for every MR.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024