Use once() and context to prevent accumulated event listeners

Open on Drupal.org →

Created on 19 February 2024, 9 months ago

Updated 3 April 2024, 8 months ago

Problem/Motivation

Currently multiple redundant event listeners are added to the elements, whenever the behavior .attach() fires.

Steps to reproduce

Install the module.
Open a node form with ajax elements. E.g. a multiple-value link field.
Inspect any text field (outside the multiple-value link element) with browser developer tools.
Check the "Event listeners" inspection tab.
Look for "blur" listeners.
Click "Add another link" on the multiple-value link field.
Refresh the event listeners inspection list.

Expected: Only one "blur" listener.
Actual: Another "blur" listener is added every time we click "Add another link".

Proposed resolution

Apply two techniques to avoid repeated listeners being added:

Use 'context' argument in the selector.
Use 'once()' as other core scripts do.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

🇩🇪Germany donquixote

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!9Use once() and context to prevent accumulated event listeners
Open
🇩🇪Germany donquixote
updated 8 months ago
!5Use once() and context to prevent accumulated event listeners
Open
🇮🇳India himanshu_jhaloya
updated 9 months ago

Comments & Activities

Issue created by @donquixote
First commit to issue fork.
Assigned to himanshu_jhaloya
Comment 9 months ago →
🇮🇳India himanshu_jhaloya Indore
Merge request !5added Use once() and context to prevent accumulated event → (Open) created by himanshu_jhaloya
Issue was unassigned.
Status changed to Needs review 9 months ago8:23am 20 February 2024
Comment 9 months ago →
🇮🇳India himanshu_jhaloya Indore
Please Review The MR.
Comment 9 months ago →
🇩🇪Germany donquixote
Does this actually work?
Which version of Drupal are you testing this with?

$(".node-form :input", context).once("node-edit-protection")
Remove jQuery dependency from the once feature →
Comment 9 months ago →
🇮🇳India himanshu_jhaloya Indore
That was drupal 8
Comment 9 months ago →
🇩🇪Germany donquixote
bq. That was drupal 8

We want this to work with Drupal 10 :)
Or maybe support different versions.
Merge request !9Issue #3422505: Use once() and context. → (Open) created by donquixote

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024