- Issue created by @rkostov
- last update
10 months ago 63 pass
I can't find the purpose/usage of the method setResponse within the classes RedirectRequestSubscriber and DomainRedirectRequestSubscriber.
It's been introduced within the class RedirectRequestSubscriber along with other methods that depend on it: redirectForum, redirectNormalizeAliases, redirectFrontPage, and redirectDeslash. Here is the commit b724cf6b4452f0e65e97bd577cd79b97affab84c. So far so good. But then, another commit d1eaf7c7a9d12fdd496e7c4ded094daf3e2ac552 has removed all these four methods rendering it useless. The class DomainRedirectRequestSubscriber was added (probably via copy-paste) a few days later with the already useless/unused method in it (commit 8b29d540aacbfbf2e6b57f0ab485d5fd7e488e8e).
If the setResponse method is not needed anymore, it must be removed to keep the codebase clean.
Needs review
1.0
Code