Make degov_simplenews compatible with simplenews 4.x

Added a patch/merge request.

Hi avogler!

Thanks for your patch! I just had a look at it and I'm not sure what motivated this change: https://git.drupalcode.org/project/degov_simplenews/-/merge_requests/2/d...

From what I can tell, the function you removed is still present in the 4.0.0 branch of simplenews.

Can you please let me know your reasoning behind the change?

Sadly I cannot reproduce it because this happened on an intermediate step while upgrading to Drupal 10. But the problem was degov_simplenews_form_alter() got invoked with an instance of SubscriptionsPageForm. This form had inherited getNewsletterIds() from SubscriptionsFormBase in the past but getNewsletterIds() got moved to SubscriptionsBlockForm some time ago (https://git.drupalcode.org/project/simplenews/-/commit/24d0fd954fe0d18f9...).

Ah okay, I can see it now! When I am on the page to manage my subscriptions, it loads the page form, which then explodes. Okay, your change makes sense here!

But I think we'll need to do some more work on this issue then. Because right now I can be an anonymous user with subscriptions and Simplenews' manage feature allows me to view the form, but degov_simplenews has no concept of this pseudo-authenticated user yet. Thus the name fields are empty and the Terms-and-conditions checkbox appears again.

I'll see if I can spend some more time on this next week!

Moin @avogler! I took some time yesterday and opened a 3.0.x branch to specifically work with Simplenews 4.

https://git.drupalcode.org/project/degov_simplenews/-/tree/3.0.x?ref_typ...

This version of the module is aware of the difference between the signup form block and the manage form page. I also had to make some other minor changes to a few form hooks. In the end that's why I opted for a separate branch for SN4 support.

I've already asked a colleague of mine to give that branch a spin to see if there are any problems I missed or introduced in this version. I'd greatly appreciate it if you could also take a look from your side!
Thanks in advance!

I gave it a short try. Looks good for me.

Okay, marking this as fixed. Will tag version 3.0.0 in a moment.

Automatically closed - issue fixed for 2 weeks with no activity.