Rename ActionPlugin Generator

Created on 14 February 2024, about 1 year ago

Problem/Motivation

When invoking Drush 12 generators, I cannot find the DRD ActionPlugin generator.

Steps to reproduce

Assuming a fresh site and module setup:
1. Open the terminal and run "drush gen drdap"
2. Should error at this point saying there's no matching generator.

Proposed resolution

1. Rename the ActionPlugin class/file to ActionPluginGenerator

Remaining tasks

Only the one step.

User interface changes

n/a

API changes

n/a

Data model changes

n/a

πŸ› Bug report
Status

Active

Version

4.1

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States fractile81

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @fractile81
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    Ah, that's bad. Is the code generator really requiring the Generator string in the class name? As the class is properly namespaced and has all the attributes, it is not necessary to enforce the naming. I wonder if we should raise that in the issue queue of the code generator?

    If not, and if you want to help us maintainers, please don't propose patches but a merge request instead. Review, collaboration, testing and merging will be so much easier for all of us - and patches won't be supported by the platform soon anyways.

  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    I've filed an issue with the code builder project: https://github.com/drupal-code-builder/drupal-code-builder-drush/issues/12

  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    Oh, I opened an issue in the wrong project: there is drupal-code-builder/drupal-code-builder which is the wrong one, but there is also Chi-teck/drupal-code-generator where I now opened the same issue as well:

    https://github.com/Chi-teck/drupal-code-generator/issues/124

  • Status changed to Needs review 3 months ago
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    Looks like neither the code generator on GitHub nor Drush is willing to change that constraint, so we have to rename the class, although I find that terribly redundant.

    Setting this issue to NR so that someone else can give the patch a try. Unfortunately, we haven't received an MR and have to go through that extra effort of dealing with a patch file. So sad!

  • Status changed to Fixed 3 days ago
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen
Production build 0.71.5 2024