- Issue created by @prudloff
- Merge request !4Issue #3420900: AlterBodySubscriber error when response HTML does not contain ___storybook_wrapper → (Merged) created by prudloff
- Status changed to Needs review
about 1 year ago 5:57pm 12 February 2024 - Status changed to Fixed
about 1 year ago 9:01am 28 February 2024 - e0ipso Can Picafort
I am a bit puzzled by this. This code should only execute when sending a response from the
storybook.render_story
controller. Which in this case is guaranteed to pass thoseif
statements, right?In any case, I am all in for defensive coding. So I will merge this one.
-
e0ipso →
committed 166c34db on 1.x authored by
prudloff →
Issue #3420900 by prudloff: AlterBodySubscriber error when response HTML...
-
e0ipso →
committed 166c34db on 1.x authored by
prudloff →
- 🇫🇷France prudloff Lille
I am a bit puzzled by this. This code should only execute when sending a response from the storybook.render_story controller.
What we do is clearly atypical and an edge-case.
(Basically we trigger a response event on a fake request in order to trigger response event subscribres on HTML that is rendered separately from the main response, kind of like what big_pipe does.)In any case, I am all in for defensive coding. So I will merge this one.
I normally would have fixed this on our side, but it seemed like a good occasion to make the storybook code more robust; I am glad we agree on this, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.