Error: Call to a member function hasTransition() on null

Adds the check for the $workflowType not to be null.

chetan 11 → made their first commit to this issue’s fork.

Please check the above MR.

@chentan11 Thanks for the MR but honestly I'm 100% sure if we're addressing the same thing. Can you please explain what your changes are doing?

Just a few observations regarding your changes:

1. Your base branch was 1.0.x one but it should be the tag 1.0.0-alpha3
2. The removed check (lines 147-149) are exactly what is required to stop the execution of the second foreach, i.e if the $workflow variable is not continue (skip) to the next step of the 1st loop (line 144)
3. What you have changed does not actually execute:
   

   if ($workflowType === null) {
     continue;
   
     foreach ($states as $state) {
       $exploded = explode(':', $state);
       if ($exploded[0] != $element_id) {
         if (!$workflowType->hasTransition($transition_id)) {
           continue;
         }
   
         $transition = $workflowType->getTransition($transition_id);
         $settings['states'][$transition_id] = $transition->label();
       }
       return $summary;
     }
   }
   

   Every time the $workflowType === null condition is met, i.e. the $workflowType is null, the continue keyword would skip the forloop and go back to line 144.

   The rest of the code block there will never execute.

Possible Solution

The check you introduced should be written as follows:

// See Drupal coding standards recommendations https://www.drupal.org/docs/develop/coding-standards/write-e_all-compliant-code
 if (is_null($workflowType)) { 
    continue;
 }

// The reset of code

This is already resolved in the latest dev, by checking if $workflowType is false. I have credited both however. There will be an alpha4 soon that will incorporate this.

Automatically closed - issue fixed for 2 weeks with no activity.