Scale back configuration generation for entity reviews

Created on 10 February 2024, 5 months ago
Updated 26 February 2024, 4 months ago

Problem/Motivation

Passing all dependent configuration to tasks means that the task has the burden of sorting through which configuration is relevant, leading to a good portion of task logic being checks. Instead pass just the entity or entity type configuration to the tasks, in addition to user-specified configuration and let the task load what it needs.

Reviewer can optionally provide services to assist with loading types of configuration (all fields on an entity for instance), or leave this to modules that provide reviews.

API changes

Add a value object for configuration passed to task check callable. The structure of the configuration parameter passed to tasks will change from

array<string, \Drupal\Core\Config\Entity\ConfigEntityInterface|\Drupal\Core\Config\ImmutableConfig>

to

\Drupal\reviewer\Reviewer\Task\TaskConfigInterface
πŸ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States benabaird

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024