- Issue created by @sea2709
- πΊπΈUnited States lemming
@sea2709 thanks for submitting a patch, this does look like a good update and I will include this with a couple updates.
- Remove the "use" declaration for "FilterPluginBase" as it is no longer used and is called out by Coder / Codesniffer
- Rather than update the EnittyBundleFilter::operators() method you can just remove it and use the parent InOperator::operators()
- Same as above with the EntityBundleFIlter::OperatorOptions(), keep the parent version, it makes use of the "$which" parameter which you added by did not implement.
- Because the operators being changed to all lowercase "in" and "not in", the default value in "::defineOptions()" needs to be updated.
- Because operators are being changes to lowercase, we need to make sure the change is compatible to existing views filters configurations which were created previously. I recommend adding an override to "EntityBundleFilter::init()" method and ensure that the:
public function init(ViewExecutable $view, DisplayPluginBase $display, array &$options = NULL) { parent::init($view, $display, $options); $this->operator = strtolower($this->options["operator"]); }
OR
public function init(ViewExecutable $view, DisplayPluginBase $display, array &$options = NULL) { $this->options['operator'] = strtolower($filter->options["operator"]); parent::init($view, $display, $options); }
- Assigned to lemming
- Status changed to Needs review
9 months ago 2:57am 15 March 2024 - πΊπΈUnited States lemming
Rolled and updated patch that addresses the issues I mentioned previously.
I tested with BEF version 6, and tried the variants of the links, select and radio/checkbox types.
- Merge request !83420562: include @sea2709 patch to extend from InOperator views filter to... β (Merged) created by lemming
- Status changed to Fixed
9 months ago 3:54am 17 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.