Contrib.social

FeedsFileSystemInterface is in Feeds module

Open on Drupal.org →
Created on 8 February 2024, 10 months ago
Updated 26 February 2024, 9 months ago

Problem/Motivation

Drupal\feeds\Feeds\Fetcher\HttpFetcher references \Drupal\Core\File\FeedsFileSystemInterface which does not exist. I think this should point to Feeds own Drupal\feeds\File\FeedsFileSystemInterface.

  /**
   * Drupal file system helper for Feeds.
   *
   * @var \Drupal\Core\File\FeedsFileSystemInterface
   */
  protected $feedsFileSystem;

  /**
   * Constructs an UploadFetcher object.
   *
   * @param array $configuration
   *   The plugin configuration.
   * @param string $plugin_id
   *   The plugin id.
   * @param array $plugin_definition
   *   The plugin definition.
   * @param \GuzzleHttp\ClientInterface $client
   *   The Guzzle client.
   * @param \Drupal\Core\Cache\CacheBackendInterface $cache
   *   The cache backend.
   * @param \Drupal\Core\File\FileSystemInterface $file_system
   *   The Drupal file system helper.
   * @param \Drupal\Core\File\FeedsFileSystemInterface $feeds_file_system
   *   The Drupal file system helper for Feeds.
   */
  public function __construct(array $configuration, $plugin_id, array $plugin_definition, ClientInterface $client, CacheBackendInterface $cache, FileSystemInterface $file_system, FeedsFileSystemInterface $feeds_file_system) {
    $this->client = $client;
    $this->cache = $cache;
    $this->fileSystem = $file_system;
    $this->feedsFileSystem = $feeds_file_system;
    parent::__construct($configuration, $plugin_id, $plugin_definition);
  }

Steps to reproduce

Proposed resolution

Annotations referencing \Drupal\Core\File\FeedsFileSystemInterface should be changed to \Drupal\feeds\File\FeedsFileSystemInterface in
Drupal\feeds\Feeds\Fetcher\HttpFetcher

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Component

Code

Created by

🇳🇿New Zealand murrow

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024