Description missed for Taxonomy terms update

Thanks for the patch!

Could you create as a merge request please?
Approach is okay, but could be improved by instead getting the config for the base fields as the root problem here is that the existing code is checking for added fields only, and should also check for base fields like taxonomy_term has

So similar to $this->configFactory->listAll('field.storage.' . $entity_type); we should get the base fields and check if they are text, text_long, etc and add as dependants.

Thanks!

Yep, completely agree. I just didn't have time to be fiddling around it. I'll take it a bit later.

All good, I'm sure your patch will already come in handy for others upgrading who use terms, so it's already a useful contribution as is :)

New shiny patch for you.

Nice this looks great, much smarter approach than loading from config. Will have to give this a proper test. Thanks very much for your work on this!

Hmmm when I run this now, the data-text attribute is empty

Steps:

1. Added a fn via 3.1.x branch within a paragraph
2. Updated to this issues branch
3. Ran the drush command drush footnotes:upgrade-3-to-4 paragraph

Okay got it, that works now. Turns out that <fn value text></fn> is also an option. Where text is on an attribute instead of within the tag. Added support for that... bit of scope creep here sorry!

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.