- Issue created by @inst
- Status changed to Closed: duplicate
11 months ago 5:55pm 7 February 2024 - 🇬🇧United Kingdom scott_euser
I think probably here is the MR with solution: https://www.drupal.org/project/footnotes/issues/3419624 🐛 DOMNode warnings when using more complex html like unordered lists in the footnote reference text Needs review
If that works for you, please feed back there as I would be keen to get it merged.
Thanks!
- 🇦🇹Austria inst
Hi,
I took a look at MR with a solution: https://www.drupal.org/project/footnotes/issues/3419624 🐛 DOMNode warnings when using more complex html like unordered lists in the footnote reference text Needs review but what do I have to do to try it out?
Is there a patch that I could try?thanks.
- 🇬🇧United Kingdom scott_euser
Sure here is how to do it https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-drupal/downloading-a-patch-file →
- 🇦🇹Austria inst
Hi,
I did put the patch in my composer.json:"extra": {
"enable-patching": true,
"patches": {
"drupal/footnotes": {
"Simplify footnotes filter to use string replacement for outputting footnotes to the text rather than saving a dom fragment": "https://git.drupalcode.org/project/footnotes/-/merge_requests/29.patch"
}
},And I made these tests with numbered list, quote and bullet list. In each I did set a footnote.
No more errors.So I think the patch was the solution.
thank you!
- 🇦🇹Austria inst
Hi,
so I was too fast. Did try it now at my productive site and the error occurs.But I am not sure why. Even, if a use a footnote in a normal text sometimes the error occurs sometimes not.
puh-.
- 🇬🇧United Kingdom scott_euser
Hi @inst,
Let's move the conversation over to that issue so we don't keep the duplicate moving. Just on the composer setup:
- You shouldn't be using the merge request patch URL, you should download it to your local machine
- Please also verify that the patch applied if you have not done it often before; have a look at the module code and see if it matches the changes in the merge request
Assuming patch applied correctly, please follow-up with your updated error that you get within that related issue.
Thanks,
Scott