"Save and edit layout" button added to any entity forms (except "delete" form)

Created on 6 February 2024, about 1 year ago

Problem/Motivation

✨ Add "Save and Edit Layout" button to entity edit pages Fixed introduced the Save and edit layout button on create and edit entity forms. Unfortunately the if-condition that checks for an instance of ContentEntityFormInterface results in the button being added to any entity form implementing that interface (except the delete form of course)

Steps to reproduce

Install layout_builder_save_and_edit module
Build a custom entity form class that implements ContentEntityFormInterface or extends ContentEntityForm class
Create a route that displays that form -> see the Save and edit layout button being added

Proposed resolution

Ensure that the Save and edit layout button is only added entity forms for relevant operations (e.g. see access_unpublished module code for a similar solution at https://git.drupalcode.org/project/access_unpublished/-/blob/8.x-1.x/src...

Remaining tasks

Create a patch/MR that fixes this issue

User interface changes

Save and edit layout button will only be added to relevant forms anymore

API changes

n/a

Data model changes

n/a

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

🇩🇪Germany hctom

Live updates comments and jobs are added and updated live.

Merge Requests

!5"Save and edit layout" button added to any entity forms (except "delete" form)
Open
🇩🇪Germany hctom
updated about 1 year ago

Comments & Activities

Issue created by @hctom
Comment about 1 year ago →
🇩🇪Germany hctom
Merge request !53419536: Ensure 'Save and edit layout' button is only added to relevant entity form pages → (Open) created by hctom
Status changed to Needs review about 1 year ago5:26pm 6 February 2024
Comment about 1 year ago →
🇩🇪Germany hctom
Please see the issue fork and MR for a proposal to fix this issue.
Status changed to RTBC 4 months ago3:06pm 5 December 2024
Comment 4 months ago →
🇺🇸United States jastraat
This fixed our issue where the save and edit layout button was appearing in the forms for scheduled_transitions → . Simple change that only adds the button where it makes sense.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024