"Save and edit layout" button added to any entity forms (except "delete" form)

Created on 6 February 2024, 5 months ago

Problem/Motivation

✨ Add "Save and Edit Layout" button to entity edit pages Fixed introduced the Save and edit layout button on create and edit entity forms. Unfortunately the if-condition that checks for an instance of ContentEntityFormInterface results in the button being added to any entity form implementing that interface (except the delete form of course)

Steps to reproduce

Install layout_builder_save_and_edit module
Build a custom entity form class that implements ContentEntityFormInterface or extends ContentEntityForm class for an entity type/bundle that has layout builder with overrides enabled
Create a route that displays that form -> see the Save and edit layout button being added

Proposed resolution

Ensure that the Save and edit layout button is only added entity forms for relevant operations (e.g. see access_unpublished module code for a similar solution at https://git.drupalcode.org/project/access_unpublished/-/blob/8.x-1.x/src...

Remaining tasks

Create a patch/MR that fixes this issue

User interface changes

Save and edit layout button will only be added to relevant forms anymore

API changes

n/a

Data model changes

n/a

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

🇩🇪Germany hctom

Live updates comments and jobs are added and updated live.

Merge Requests

!5"Save and edit layout" button added to any entity forms (except "delete" form)
Open
🇩🇪Germany hctom
updated 5 months ago

Comments & Activities

Issue created by @hctom
Comment 5 months ago →
🇩🇪Germany hctom
Merge request !53419536: Ensure 'Save and edit layout' button is only added to relevant entity form pages → (Open) created by hctom
Status changed to Needs review 5 months ago5:26pm 6 February 2024
Comment 5 months ago →
🇩🇪Germany hctom
Please see the issue fork and MR for a proposal to fix this issue.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024