- Issue created by @pmagunia
- Issue was unassigned.
- last update
11 months ago 2 pass - Assigned to itmaybejj
- 🇺🇸United States itmaybejj
Aww I thought it would be nice to translate them, but if you're testing this live and saying it doesn't work I'll roll this into the next release.
- 🇺🇸United States pmagunia Philadelphia 🇺🇸
Thanks for getting back so quickly.
A client on a Windows machine was having difficulty opening the file.
-
itmaybejj →
committed e12a9195 on 2.1.x authored by
pmagunia →
Issue #3419299 by pmagunia: Translating CSV filenames causes download...
-
itmaybejj →
committed e12a9195 on 2.1.x authored by
pmagunia →
- Status changed to Needs review
10 months ago 10:12pm 8 February 2024 - Status changed to Fixed
10 months ago 7:05pm 14 February 2024 - 🇨🇦Canada kpaxman
looking at the patch I wonder if the issue was just that the old version didn't have a period in front of "csv"...IIRC Windows is horrible at guessing what things are if files don't have a proper extension, and many users don't think beyond double-clicking the file.
- 🇺🇸United States itmaybejj
Bingo -- that was the actual issue.
But once I was in there debugging, I realized that translations might insert spaces ("los resultados")...and I didn't want to head down the rabbit hole of trying to sanitize translations for Windows-friendly filenames.
- 🇨🇦Canada kpaxman
Gotcha. I can understand not wanting to go down rabbit holes. :)
Automatically closed - issue fixed for 2 weeks with no activity.