Contrib.social

"Allow In Progress Booking" is not respected in instances list

Open on Drupal.org →
Created on 5 February 2024, about 1 year ago
Updated 19 March 2024, about 1 year ago

Problem/Motivation

Given an opening instance with a setup like

  • start time 08:00, end time 17:00
  • lead time "now"
  • "Allow in progress booking" is checked

then I expect the instance to be bookable until 17:00.

But currently the "book_in_progress" is ignored, because the Renderer returning available instances only checks for leadling time. After 08:00 the instance is filtered out, even though "book_in_progress" is enabled.

Proposed resolution

If "book_in_progress" is enabled, the leading time should be calculated from the END time of the instance, not from the start time of the instance.

  1. given a setup with: open from 08:00 to 17:00 + leading time "now" + "Allow in Progress booking" enabled ==> allow booking until 17:00
  2. given a setup with: open from 08:00 to 17:00 + leading time "1 hour" + "Allow in Progress booking" enabled ==> allow booking until 16:00
  3. given a setup with: open from 08:00 to 17:00 + leading time "now" + "Allow in Progress booking" disabled ==> allow booking until 08:00
  4. given a setup with: open from 08:00 to 17:00 + leading time "1 hour" + "Allow in Progress booking" disabled ==> allow booking until 07:00
🐛 Bug report
Status

Fixed

Version

2.2

Component

Code

Created by

🇦🇹Austria hudri Austria

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024