- Issue created by @rsnyd
We are also seeing issues with this module after updating to Drupal 10.2. The problem looks to be related to Drupal's switch to a different HTML parser: https://www.drupal.org/node/3225468 → .
Our solution for now is to patch this module to use the old HTML parsing code from Html::load() in Drupal 10.1.8. I've attached a patch for your reference. This probably isn't a great solution but it gets us unstuck.
Also, just wanted to say thanks for contributing this module! We really needed it in order for us to upgrade to Drupal 10 and CKEditor 5.
- Status changed to Needs review
7 months ago 2:42am 6 March 2024 - 🇪🇨Ecuador jwilson3
The above MR is a copy/paste of Drupal core 10.2's
Drupal\filter\Plugin\Filter\FilterHtml::getHTMLRestrictions()function.It might make sense to simply subclass from Drupal\filter\Plugin\Filter\FilterHtml to simply inherit that function, such that we can trim down the amount of duplicate (forked) code required to make this module run, while keeping parity with whatever version of Drupal the end user is using. But I would consider that task a follow-up and out of scope of this issue.
Here is a copy of the MR in patch form, in case someone was already using the old patch and wants a more correct, more lightweight new patch.
- Assigned to DuttonMa
- Status changed to Fixed
6 months ago 9:52am 26 March 2024 - 🇬🇧United Kingdom DuttonMa
Thanks for all comments and work on this. New release 1.2.x-dev is now available that fixes all Drupal 10.2 compatibility problems, so please use that version.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇪🇨Ecuador jwilson3
Spent +1 hour on this for a client. Disappointed to see no issue credit awarded. :-/
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... →