- Issue created by @banoodle
- Status changed to Needs review
11 months ago 3:42am 1 February 2024 - Status changed to Fixed
9 months ago 4:19am 16 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.
Love this module, but ran into a problem with Group menus (provided by the Group Content Menu → module). After enabling the recommended release of Domain Menus, the problem started. I get the following fatal errors when attempting to add or edit a group menu link. No problems on regular menus or domain menus.
Error: Call to a member function getThirdPartySetting() on null in domain_menus_menu_link_content_access() (line 362 of modules/contrib/domain_menus/domain_menus.module).
It's possible this is really a Group Content Menu bug, but my debugger led me to a fix that seems to address my problem. So I plan to submit a patch here that seems to be working well for me.
The problem is Menu::load on a group menu id (e.g., group_menu_link_content-2) returns null.
Just fence off the Menu::load methods so they aren't fired if $menu is null. I realize this probably means my group menus can't take advantage of Domain Menus functionality, but for my current project, that isn't a deal-breaker.
Submitting patch momentarily.
None.
None.
None.
Fixed
3.0
Code
Automatically closed - issue fixed for 2 weeks with no activity.