Don't run trackItemsDeleted when $item_ids is empty

Created on 1 February 2024, 10 months ago

Updated 15 February 2024, 9 months ago

Problem/Motivation

In some scenarios (in my case during tests) search_api_revisions_entity_predelete can run when an entity is already deleted which means there are no revisions, resulting in $index->trackItemsDeleted($datasource_id, $item_ids); being called with an empty array.

Steps to reproduce

Index items in a test using drupal-test-traits, mark those entities for cleanup and run the test twice.

Proposed resolution

Check if empty.

🐛 Bug report

Status

Fixed

Version

2.0

Component

Code

Created by

🇦🇺Australia acbramley

Live updates comments and jobs are added and updated live.

Merge Requests

!9Don't run trackItemsDeleted when $item_ids is empty
Merged
🇦🇺Australia acbramley
updated 10 months ago

Comments & Activities

Issue created by @acbramley
Merge request !9Resolve #3418514 "Dont run trackitemsdeleted" → (Merged) created by acbramley
Pipeline finished with Skipped
10 months ago
#85729
Comment 10 months ago →
System Message

acbramley → committed 4cafdaf8 on 2.x
Issue #3418514: Don't run trackItemsDeleted when $item_ids is empty
Status changed to Fixed 10 months ago2:06am 1 February 2024
Comment 10 months ago →
🇦🇺Australia acbramley
Comment 9 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024