Revisions controller getRevisionIds() should filter by language

Created on 31 January 2024, 8 months ago
Updated 1 February 2024, 8 months ago

Problem/Motivation

The \Drupal\diff\Controller\PluginRevisionController::compareEntityRevisions() calls getRevisionIds() for all languages and then determines if the language matches by loading the revision. This can be problematic on a site with lots of revisions.

Proposed resolution

Update \Drupal\diff\Controller\PluginRevisionController::getRevisionIds() to filter the query by "langcode" and "revision_translation_affected".

πŸ› Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States recrit

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024