- Issue created by @fjgarlin
- πͺπΈSpain fjgarlin
fjgarlin β changed the visibility of the branch 3418313-if-a-project to hidden.
- Merge request !223Resolve #3418313 "Show avatar after logo is added" β (Closed) created by fjgarlin
- Status changed to Needs review
11 months ago 10:40am 31 January 2024 - πͺπΈSpain fjgarlin
The cached was removed, but it's needed for when projects don't have the logo yet.
This is setting a 1h cache for empty values, and permantent for non-empty values.Ready to review: https://git.drupalcode.org/project/drupalorg/-/merge_requests/223
- πΊπΈUnited States drumm NY, US
This should already be cleared on commit with https://git.drupalcode.org/project/drupalorg/-/blob/94be4936e3fa81396312...
- πͺπΈSpain fjgarlin
Oh! I forgot we did that. Good catch!
I can see the commit for the logo on January 3rd 2024 for this project: https://git.drupalcode.org/project/config_patch_gitlab_api, but no logo shown here https://www.drupal.org/project/config_patch_gitlab_api β .
I'll ask them to make another commit just in case.
- Status changed to Closed: works as designed
11 months ago 4:38pm 5 February 2024 - πΊπΈUnited States drumm NY, US
I confirmed that cache clearing is working. There is also caching at the CDN for the project avatar. That should also be actively cleared on push as well. It takes a few seconds for the CDN cache to clear, so this likely was a race condition. We can look closer if it becomes a recurring problem.