Contrib.social

fields() function broken

Open on Drupal.org →
Created on 30 January 2024, over 1 year ago

Problem/Motivation

Call to a member function getColumnNames() on null, because $this->file doesn’t exist

Steps to reproduce

When calling dr migrate:fields-source, the error above appears

Proposed resolution

   public function fields() {
+    $result = $this->getQueryResults();
     $fields = [];
-    if (!$this->file) {
-      $this->initializeIterator();
+    foreach ($result->fetchAssoc() as $key => $column) {
+      $fields[$key] = $key;
     }
-    foreach ($this->file->getColumnNames() as $column) {
-      $fields[key($column)] = reset($column);
-    }
-
-    // Any caller-specified fields with the same names as extracted fields will
-    // override them; any others will be added.
-    $fields = $this->getConfiguration()['fields'] + $fields;
 
     return $fields;
   }

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs review

Version

1.3

Component

Code

Created by

🇩🇪Germany gogowitsch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024