- Issue created by @MacSim
- Status changed to Needs review
5 months ago 1:28am 30 January 2024 - π«π·France MacSim
Note: When we'll want to drop Drush 11 support, we'll just have to remove the
drush.services.yml
file. - π¬π§United Kingdom AdamPS
Great thanks. Did you test with both Drush 11 and 12?
> Note: When we'll want to drop Drush 11 support, we'll just have to remove the drush.services.yml file.
Please could you raise an issue? - Status changed to Needs work
5 months ago 5:40pm 10 February 2024 - π¬π§United Kingdom AdamPS
AFAICS it works without this change in Drush 12. According to https://www.drush.org/12.x/commands/, the old way is deprecated in Drush 12 and will be removed in Drush 13. This change is still a good idea, it would be clearer to update the IS and title.
To prove this patch works I suggest that we need a version that removes the services file. We won't commit it however we can check that it's working.
- π«π·France MacSim
@AdamPS
Did you test with both Drush 11 and 12?
Nope I didn't. I thought reviewers would do it.
Please could you raise an issue?
I can but I would say that it should be done in a 1.5.x version which doesn't exist right now.
We would also need to add the following lines to thecomposer.json
:"conflict": { "drush/drush": "<12" }
AFAICS it works without this change in Drush 12.
Did you tried to use the command on 1.4.1 with drush 12?
Cause it should throw a "mailer:override command is undefined" error.The doc says that
drush.services.yml
is deprecated in drush 12 and will be removed in Drush 13.
But it also says that- Drush 12 expects commandfiles to use a create() method to inject Drupal and Drush dependencies.
- Drush 12 expects all commandfiles in the /Drush/ directory. The Drush subdirectory is a new requirement.
Those changes are required to run a command with drush 12.
- π¬π§United Kingdom AdamPS
Did you tried to use the command on 1.4.1 with drush 12?
Yes it is working fine for me.