Contrib.social

Prevent random build test failures by preventing stage IDs from starting with -

Open on Drupal.org →
Created on 29 January 2024, over 1 year ago
Updated 13 February 2024, over 1 year ago

Problem/Motivation

Right now, Automatic Updates' build tests occasionally fail randomly. This happens because the stage ID (which is randomly generated) ends up beginning with a -, which looks like a command-line option to the auto-update post-apply console command. We've tried escaping the stage ID argument, specifically to prevent these random failures, but it has not worked.

Proposed resolution

Stage IDs should never begin with a dash. Let's trim it off when the stage ID is generated.

Remaining tasks

Implement it. Since the stage ID is randomly generated by a static class method, I can't think of a way to test this. But really, the content of the stage ID doesn't matter; if this works, we'll never see this random failure again.

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇺🇸United States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024