- Issue created by @k-l
- Merge request !14Add support for LocalDisposableOnly and LocalFreeOnly configuration → (Merged) created by k-l
- last update
10 months ago 7 pass - Status changed to Needs work
10 months ago 9:56pm 30 January 2024 - 🇦🇺Australia darvanen Sydney, Australia
This is fantastic, thank you, great work. I've marked just one nitpick but otherwise this is ready to ship. I'm happy to make the change myself and commit but I ran out of time this morning.
- 🇦🇺Australia darvanen Sydney, Australia
Oh I forgot about tests, it would be really great if this had a test.
- Status changed to Postponed
8 months ago 12:37pm 24 March 2024 - 🇦🇺Australia darvanen Sydney, Australia
The test has uncovered the fact that the provider results get statically cached in each request. If we change the configuration part way through (say if we're validating a different field that has a different set of overrides) we're going to run into issues. We'll need to get that sorted out before we can commit this.
I'll raise a PR on the external library if I can figure out how to make it work. Postponing on that.
- 🇦🇺Australia darvanen Sydney, Australia
Ah there's already an issue raised and the maintainer self-assigned yesterday, good timing :)
- Status changed to Needs review
8 months ago 10:47pm 9 April 2024 - 🇦🇺Australia darvanen Sydney, Australia
https://github.com/stymiee/email-validator/releases/tag/1.1.4 just came out which should unstick this, running the tests again now.
- Status changed to Needs work
8 months ago 10:51pm 9 April 2024 - 🇦🇺Australia darvanen Sydney, Australia
Tests passed. Think we'd better bump the minimum version of the library since that's required to solve this bug.
- Status changed to RTBC
8 months ago 11:05pm 9 April 2024 -
darvanen →
committed e28342ae on 1.0.x authored by
k-l →
Issue #3417829 by darvanen, k-l: Add support for localDisposableOnly and...
-
darvanen →
committed e28342ae on 1.0.x authored by
k-l →
- Status changed to Fixed
8 months ago 11:10pm 9 April 2024 - 🇦🇺Australia darvanen Sydney, Australia
Thanks so much for your work on this @k-l :)
Automatically closed - issue fixed for 2 weeks with no activity.