- Status changed to Needs review
10 months ago 10:08am 30 January 2024 - 🇮🇳India abhishek_virasat
@willemviljoen, fix the issue and created Patch. please kindly review patch file
When a block is placed via 'Block layout' with 'Context (All)' condition set, it continues to display on the homepage even if the specified context is disabled.
The block should not be displayed on the homepage when its associated context is disabled.
The block remains visible on the homepage even when the associated context is disabled.
In ContextAll.php, modify the condition check to properly account for disabled contexts. Change:
if (!$this->contextManager->evaluateContextConditions($required_context) && !$required_context->disabled()) {
return FALSE;
}
To:
if (!$this->contextManager->evaluateContextConditions($required_context) || $required_context->disabled()) {
return FALSE;
}
Needs review
5.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
@willemviljoen, fix the issue and created Patch. please kindly review patch file