Contrib.social

setWebform waits for an int - Makes PHPStan fail

Open on Drupal.org →
Created on 23 January 2024, over 1 year ago

Problem/Motivation

Function WebformQuery::setWebform() waits an int (for parameter $webform_id) as first argument, according to its docblock.

This makes PHPStan fail when checking code quality:

> ./vendor/bin/phpstan
Note: Using configuration file /var/www/phpstan.neon.
 51/51 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------------------------------------------- 
  Line   [...]/MyModuleCommands.php                              
 ------ -------------------------------------------------------------------------------------------------------------------- 
  89     Parameter #1 $webform_id of method Drupal\webform_query\WebformQuery::setWebform() expects int|null, string given.  
 ------ -------------------------------------------------------------------------------------------------------------------- 

 [ERROR] Found 1 error

Proposed resolution

Document this function as expecting a string.

🐛 Bug report
Status

Active

Component

Code

Created by

🇫🇷France pacproduct

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024