Sub-theme's 'dist/script.js' is not added to a list of PHPCS exclusions when running 'npm run build'

Created on 19 January 2024, 5 months ago

Updated 26 March 2024, 3 months ago

Summary
When running in the sub-theme created from the starter kit, the compiled JS get's PHPCS exclusion comments added automatically.

This works for JS files in `sotrybook-static` directory, but not for js files in `dist`directory.

As a result - the PHPCS linting always reports violations on the file `dist/styles.css`

Steps to reproduce
Using GovCMS SaaS scaffold:

1. Create a subtheme
2. Run `npm ci`
3. Run `npm run lint`

Observed outcome
CSS files is scanned by phpcs and reported as a file with violations.

🐛 Bug report

Status

Fixed

Version

1.6

Component

Code

Created by

🇦🇺Australia alex.skrypnyk Melbourne

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @alex.skrypnyk
Assigned to alex.skrypnyk
Status changed to Fixed 4 months ago7:09pm 12 March 2024
Comment 4 months ago →
🇦🇺Australia alex.skrypnyk Melbourne
Fixed in https://git.drupalcode.org/project/civictheme/-/commit/26954096e6ab26d24...
Will be released in 1.7

Will require update to current themes. Release notes will be mentioning this.
Comment 3 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024