- Issue created by @dcam
- πΊπΈUnited States dcam
Removed the related issue since I declared that to be a child of this issue.
- πΊπΈUnited States dcam
I've applied the quick-fix to the blocks: specifying the
canonical
link template intoUrl()
. This will allow us to see if the π Blocks cause WSOD; Cannot generate default URL Active change really does fix the "Congratulations, you upgraded Drupal!" failures shown here. Then we'll have greater confidence that the other issue's MR should be merged. - πΊπΈUnited States dcam
This issue's branch was rebased from 2.x since the block fix was committed. Here's the updated list of failures:
1) Drupal\Tests\aggregator\Functional\AggregatorRenderingTest::testBlockLinks Behat\Mink\Exception\ResponseTextException: The text "feed-pjr4bka2jv" appears in the text of this page, but it should not. /builds/project/aggregator/vendor/behat/mink/src/WebAssert.php:907 /builds/project/aggregator/vendor/behat/mink/src/WebAssert.php:312 /builds/project/aggregator/tests/src/Functional/AggregatorRenderingTest.php:84 /builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 2) Drupal\Tests\aggregator\Functional\ItemCacheTagsTest::testEntityCreation TypeError: Drupal\Tests\system\Functional\Entity\EntityCacheTagsTestBase::verifyRenderCache(): Argument #1 ($keys) must be of type array, string given, called in /builds/project/aggregator/tests/src/Functional/ItemCacheTagsTest.php on line 75 /builds/project/aggregator/web/core/modules/system/tests/src/Functional/Entity/EntityCacheTagsTestBase.php:647 /builds/project/aggregator/tests/src/Functional/ItemCacheTagsTest.php:75 /builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 -- There were 2 failures: 1) Drupal\Tests\aggregator\Functional\migrate_drupal_ui\d6\UpgradeTest::testUpgrade Failed asserting that two arrays are identical. --- Expected +++ Actual @@ @@ Array &0 ( 'aggregator_feed' => 1 'aggregator_item' => 1 - 'block' => 36 + 'block' => 37 'entity_view_display' => 58 'entity_view_mode' => 14 'view' => 16 ) /builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121 /builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/Constraint/IsIdentical.php:79 /builds/project/aggregator/tests/src/Functional/migrate_drupal_ui/MigrateUpgradeExecuteTestBase.php:90 /builds/project/aggregator/tests/src/Functional/migrate_drupal_ui/MigrateUpgradeExecuteTestBase.php:30 /builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 2) Drupal\Tests\aggregator\Functional\migrate_drupal_ui\d7\UpgradeTest::testUpgrade Failed asserting that two arrays are identical. --- Expected +++ Actual @@ @@ Array &0 ( 'aggregator_feed' => 1 'aggregator_item' => 10 - 'block' => 27 + 'block' => 28 'entity_view_display' => 35 'entity_view_mode' => 13 'view' => 16 ) /builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121 /builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/Constraint/IsIdentical.php:79 /builds/project/aggregator/tests/src/Functional/migrate_drupal_ui/MigrateUpgradeExecuteTestBase.php:90 /builds/project/aggregator/tests/src/Functional/migrate_drupal_ui/MigrateUpgradeExecuteTestBase.php:30 /builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
- πΊπΈUnited States dcam
The verifyRenderCache() error is related to this CR: https://www.drupal.org/node/3354596 β .
- First commit to issue fork.
- Status changed to Fixed
10 months ago 9:31pm 18 January 2024 - πΊπΈUnited States dcam
Teamwork for the win. Thank you again, @larowlan!
Automatically closed - issue fixed for 2 weeks with no activity.