DefaultFacetsSummaryManager filters facets in wrong place

Created on 18 January 2024, 5 months ago

Problem/Motivation

If you have multiple facet summaries, each with different facet selections, the facet config from only the first one is applied to the facet list for all of them. This means that a summary with no facets effectively disables the facets on subsequent facets.

Steps to reproduce

- Create a summary with no facets and another with facets and places blocks in that order.
- The second summary will be missing facets.

Proposed resolution

The problem is that DefaultFacetsSummaryManager->getFacets stores the facets for the facetsource but filters by the specific summary facets. Unfortunately subsequent method calls use this list and it isn't updated because it is is only populated on the first run.

I propose moving the summary-specific filtering to a later point when it is building the facet summary.

πŸ› Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

πŸ‡¬πŸ‡§United Kingdom very_random_man

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024