- Issue created by @prudloff
- last update
6 months ago Composer require-dev failure - Status changed to Needs review
6 months ago 11:08am 15 January 2024 - 🇦🇹Austria drunken monkey Vienna, Austria
Thanks for reporting this problem and already providing a solution!
I wasn’t aware that the time-based cache plugin for SQL views also added list cache tags, otherwise we would probably have done the same. Anyways, since it’s been working like that for a while now, I agree that we probably shouldn’t change this behavior. Adding a new cache plugin that implements this behavior does seem more sensible.
However, as with all new features, it would be good to hear from a few others first that would also find this useful. I want to avoid adding features that are too niche.Also, before merging this, we’ll definitely need some test coverage. This could probably be largely based on the existing tests for the time-based cache plugin, just with some of the assertions changed/reversed.
- Status changed to Postponed
5 months ago 5:00pm 6 February 2024 - 🇦🇹Austria drunken monkey Vienna, Austria
Discussing this now as part of #3327645-18: View recalculated with wrong data from cache → , please see there. If we resolve it there, this issue becomes outdated, otherwise I’d move it back to NW.
- Status changed to Needs work
5 months ago 4:44pm 12 February 2024 - 🇦🇹Austria drunken monkey Vienna, Austria
Based on 🐛 View recalculated with wrong data from cache Needs review , the current behavior of the time-based cache plugin is intended and should not be changed.
So you’re right in your approach, the only thing to resolve this issue would be to add a third Search API-specific cache plugin that invalidates based both on cache tags and max-age. I can imagine that that would also be useful to a significant portion of sites. However, hearing from more potential users would of course be great.In any case, this still needs tests. Shouldn’t be too hard, though, using the existing
ViewsDisplayCachingTest
. - 🇦🇹Austria drunken monkey Vienna, Austria
Oh, and please use patches instead of issue forks for development in this project, at least until we get 📌 (Try to) fix the GitLab CI RTBC resolved.