Contrib.social

Fix Views Menus

Open on Drupal.org →
Created on 14 January 2024, 5 months ago

Problem/Motivation

The integration to use icon in views menu items does not work as expected.

There is also an issue where the option to choose the prefix/suffix icon for the menu is shown in most views configuration forms that have nothing to do with menus.

Steps to reproduce

  1. Edit a view display for a page
  2. In the Title section, open the Title form and note the Icons fieldset is shown
  3. In the Advanced section, open the Query settings form and note the Icons fieldset is shown
  4. In the Advanced section, open the Caching form and note the Icons fieldset is shown
  5. Open the Menu form
  6. Note that the Icon fieldset's elements do not have titles
  7. Choose an icon for both elements and save the menu settings
  8. Visit a page with this view's menu and note that it has no icons in the menu name

Proposed resolution

Fix these issues.

🐛 Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

🇨🇦Canada mdolnik

Live updates comments and jobs are added and updated live.
  • views

    Involves, uses, or integrates with views. In Drupal 8 core, use the “VDC” tag instead.

Sign in to follow issues

Comments & Activities

  • Issue created by @mdolnik
  • Status changed to Needs review 5 months ago
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
    last update 5 months ago
    Waiting for branch to pass
  • Comment 5 months ago →
    🇨🇦Canada mdolnik
    1. Modified icons_form_views_ui_edit_display_form_alter() to only display the icon settings on the views menu form
    2. Modified icons_form_views_ui_edit_display_form_alter() to add Prefix/Suffix titles to the elements
    3. Modified IconsManager::getMenuItemIcons() to retrieve the icon values from the correct area in the $options array.
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024