- Issue created by @phenaproxima
- Assigned to tedbow
- Status changed to Needs review
about 1 year ago 4:02pm 12 January 2024 - Assigned to phenaproxima
- πΊπΈUnited States tedbow Ithaca, NY, USA
How can we run this against 10.1.x with the contrib version to make sure it still passes?
Ideally 3.0.x would be tested against both 10.2.x and 10.1.x but at the least I think we need be able to test before commit.
- πΊπΈUnited States phenaproxima Massachusetts
As with Drupal CI, it is possible to trigger a pipeline manually against a different branch of core (in the case of 10.1.x, that would be
$CORE_SECURITY_PREVIOUS_MINOR
). You can also do that for branches in an issue fork.It's a tad cumbersome, but not much worse than what we had to do with Drupal CI. Remember:
- It only tested one branch automatically on commit (GitLab CI is the same way)
- If you wanted to test it against a different branch, you had to fill out a form to do that (same thing with GitLab CI)
- Status changed to Needs work
about 1 year ago 11:00pm 17 January 2024 - Assigned to tedbow
- πΊπΈUnited States tedbow Ithaca, NY, USA
Working on patch failures in conversion
- Status changed to Needs review
about 1 year ago 9:06pm 24 January 2024 - Assigned to phenaproxima
- Status changed to Needs work
about 1 year ago 6:25pm 31 January 2024 - Assigned to tedbow
- Assigned to phenaproxima
- Status changed to Needs review
about 1 year ago 8:20pm 3 March 2024 - πΊπΈUnited States tedbow Ithaca, NY, USA
Tests are on passing now on the module converted to the core version and testing as part of core 11.x!
- Assigned to tedbow
- Status changed to Needs work
about 1 year ago 1:58pm 4 March 2024 - πΊπΈUnited States phenaproxima Massachusetts
I'm pretty happy with this. A few minor points.
- πΊπΈUnited States tedbow Ithaca, NY, USA
The last test failure was actually because of core issue π Fix root namespace classes DebugClassLoader forward compatibility warnings Needs work that was since reverted. It caused an incompatibility with Core 11.x and php 8.3.
Running the tests again, I think it should pass now
- Assigned to phenaproxima
- Status changed to Needs review
about 1 year ago 2:43am 6 March 2024 - πΊπΈUnited States tedbow Ithaca, NY, USA
@phenaproxima I think I have addressed your points and the tests should pass now that π Fix root namespace classes DebugClassLoader forward compatibility warnings Needs work has been reverted
- Status changed to RTBC
about 1 year ago 3:34am 6 March 2024 - πΊπΈUnited States phenaproxima Massachusetts
I worked a lot on this so I might not be the one to RTBC it, but I'm doing so anyway. I think this looks good. With this change, we're really covering all our bases with tests and it makes verifying the core merge request a lot easier.
-
tedbow β
committed 917d77d7 on 3.0.x authored by
phenaproxima β
Issue #3414168: Add a new CI job that creates a core version of...
-
tedbow β
committed 917d77d7 on 3.0.x authored by
phenaproxima β
- Status changed to Fixed
about 1 year ago 4:09am 6 March 2024 - πΊπΈUnited States tedbow Ithaca, NY, USA
@phenaproxima thanks. I agree this is really good to add test coverage for the conversion and testing as the core module!
Automatically closed - issue fixed for 2 weeks with no activity.