Add a new CI job that creates a core version of Automatic Updates and Package Manager, and runs their tests

Created on 11 January 2024, 6 months ago
Updated 20 March 2024, 3 months ago

Problem/Motivation

Ideally we'd test Automatic Updates and Package Manager as core modules, before submitting the modules to a core merge request. With GitLab CI, it's possible!

The first step, I think, is to create a CI job which converts the modules to their core versions, then exposes those converted files as an artifact.

Once we have that, we can use it to trigger a secondary PHPUnit job matrix, which runs the converted modules' tests.

πŸ“Œ Task
Status

Fixed

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • Merge request !1017Add a core-convert job β†’ (Merged) created by phenaproxima
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • Assigned to tedbow
  • Status changed to Needs review 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • Assigned to phenaproxima
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    How can we run this against 10.1.x with the contrib version to make sure it still passes?

    Ideally 3.0.x would be tested against both 10.2.x and 10.1.x but at the least I think we need be able to test before commit.

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    As with Drupal CI, it is possible to trigger a pipeline manually against a different branch of core (in the case of 10.1.x, that would be $CORE_SECURITY_PREVIOUS_MINOR). You can also do that for branches in an issue fork.

    It's a tad cumbersome, but not much worse than what we had to do with Drupal CI. Remember:

    • It only tested one branch automatically on commit (GitLab CI is the same way)
    • If you wanted to test it against a different branch, you had to fill out a form to do that (same thing with GitLab CI)
  • Pipeline finished with Failed
    6 months ago
    #78728
  • Status changed to Needs work 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    Merged [#3415403}

  • Pipeline finished with Failed
    6 months ago
    #78982
  • Pipeline finished with Canceled
    5 months ago
    Total: 29s
    #82026
  • Pipeline finished with Failed
    5 months ago
    Total: 1620s
    #82018
  • Pipeline finished with Failed
    5 months ago
    Total: 271s
    #82027
  • Assigned to tedbow
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    Working on patch failures in conversion

  • Pipeline finished with Failed
    5 months ago
    Total: 1066s
    #82030
  • Pipeline finished with Failed
    5 months ago
    Total: 751s
    #82038
  • Pipeline finished with Failed
    5 months ago
    Total: 575s
    #82041
  • Pipeline finished with Failed
    5 months ago
    Total: 1079s
    #82043
  • Pipeline finished with Failed
    5 months ago
    Total: 637s
    #82051
  • Status changed to Needs review 5 months ago
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • Pipeline finished with Failed
    5 months ago
    Total: 2720s
    #82053
  • Pipeline finished with Failed
    5 months ago
    #85487
  • Assigned to phenaproxima
  • Status changed to Needs work 5 months ago
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA
  • Assigned to tedbow
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA
  • Pipeline finished with Failed
    5 months ago
    Total: 45634s
    #86484
  • Pipeline finished with Failed
    4 months ago
    Total: 1313s
    #107478
  • Pipeline finished with Failed
    4 months ago
    Total: 1436s
    #107491
  • Pipeline finished with Success
    4 months ago
    Total: 1431s
    #109766
  • Assigned to phenaproxima
  • Status changed to Needs review 4 months ago
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    Tests are on passing now on the module converted to the core version and testing as part of core 11.x!

  • Assigned to tedbow
  • Status changed to Needs work 4 months ago
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    I'm pretty happy with this. A few minor points.

  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    The last test failure was actually because of core issue πŸ“Œ Fix root namespace classes DebugClassLoader forward compatibility warnings Needs work that was since reverted. It caused an incompatibility with Core 11.x and php 8.3.

    Running the tests again, I think it should pass now

  • Pipeline finished with Success
    4 months ago
    Total: 113013s
    #110885
  • Assigned to phenaproxima
  • Status changed to Needs review 4 months ago
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    @phenaproxima I think I have addressed your points and the tests should pass now that πŸ“Œ Fix root namespace classes DebugClassLoader forward compatibility warnings Needs work has been reverted

  • Status changed to RTBC 4 months ago
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    I worked a lot on this so I might not be the one to RTBC it, but I'm doing so anyway. I think this looks good. With this change, we're really covering all our bases with tests and it makes verifying the core merge request a lot easier.

  • Pipeline finished with Skipped
    4 months ago
    #112413
  • Status changed to Fixed 4 months ago
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    @phenaproxima thanks. I agree this is really good to add test coverage for the conversion and testing as the core module!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024