Media Library Importer MEGA Refactoring and General Improvements

Created on 10 January 2024, over 1 year ago
Updated 25 January 2024, about 1 year ago

Problem/Motivation

I am main maintainer of Geofield stack of modules (Geofield, Geofield Map, Leaflet) and Geocoder module also, and I discovered and have been using this module in a related project of mine.
I liked (and still like) the initial approach and inspiring need of this module, BUT I found it (and still find it in its latest 2.0.0-beta1) pretty limited, not properly scalable and configurable, so as heavily not PHP & Drupal coding standards compliant ...

Proposed resolution

As I feel it could provide more solid, established and general benefits to the whole Drupal 10 & Media community, I performed a deep and complete refactoring and enhancement of the Media Library Importer module as a whole, still preserving its more solid foundations.
I am going to provide here as MR (merge request), with much more details on the refactored areas of its code base and functional logics.

If approved and this going to be merged ... I give to the main maintainer (@salihcenap) my availability to become (and be appointed) as co-maintainer of it.

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇮🇹Italy itamair

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @itamair
  • Status changed to Needs review over 1 year ago
  • 🇮🇹Italy itamair

    Implementation details have been added to the MR description ...

  • First commit to issue fork.
  • 🇹🇷Turkey salihcenap

    Dear Italo Mairo,

    Thanks for your interest in enhancement of the Media Library Importer module.

    As I cannot dedicate much time for this project your contributions are happily welcomed!

    I have invited you as a co-maintainer.

    Let's do this together! :-)

  • Status changed to Fixed over 1 year ago
  • 🇮🇹Italy itamair

    Thanks so much @salihcenap ...
    BUT it looks that I don't have enough permissions for doing much there. I can see myself among the module maintainers , but may be you gave me just the "Write to VCS"?
    You should provide me also all the following ones:
    - Edit project;
    - Maintain issues;
    - Administer releases;

    to allow me to properly contribute and eventually deploy new releases, unless you want to keep them and can guarantee some short feedback / response on those.

    As long as you don't give me the "Administer maintainers" permission you still keep the main control over the other maintainers.

  • 🇮🇹Italy itamair

    It looks the module is not following proper Drupal semantic versioning ( https://www.drupal.org/node/1015226#s-release-branches ) in its branch and releases.

    The actual 2.0.0-beta1 is being released on the 1.x branch ...

    Instead we should work on a new 2.x branch and probably release a new 2.0 release of the module, for expositing it to "composer require".
    Also the dev branch itself (1.x or 2.x) should be exposed to "composer require" to let everybody require and test the dev branch and latest GIT HEAD ...

    If you give me "Administer releases" privilege I can fix and properly setup all this ...

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024