Contrib.social

Update test coverage relating to libxml2 library

Open on Drupal.org →
Created on 9 January 2024, 6 months ago
Updated 23 January 2024, 5 months ago

Problem/motivation

Test coverage in UrlEmbedTestBase.php was written 8 years ago to accommodate how Drupal's htmlcorrector filter behaves, and the code included a @todo to remove it when 🌱 [Meta] PHP DOM (libxml2) misinterprets HTML5 Active was fixed:

/**
* The expected output of the Flickr URL in a WYSIWYG.
*
* Embeds rendered via the url_embed filter generate XHTML4 markup due to
* deficiencies with libxml2.
*
* @todo Remove once https://www.drupal.org/node/1333730 → lands.
*/

As a result, tests currently fail on Drupal 10.2.x

Proposed resolution

Update the test coverage to expect standard HTML5 output.

This module uses Gitlab CI for automated testing of proposed code changes. To contribute code changes, create a merge request. Patch files will not trigger automated testing and are not sufficient for review.
📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States mark_fullmer Tucson

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024