- Issue created by @sluc23
- 🇨🇦Canada karing 🇨🇦
Hi @sluc23 - I generally don't create tags for the Github repo. On the other hand I will always issue a Tag when pushing to drupal.org as part of the issuing a release process, so options are:
Manage using Tags
use https://git.drupalcode.org/project/webform_civicrmBe fully up to date - to the latest commit
git clone https://github.com/colemanw/webform_civicrm.gitOr - latest packaged release
composer require 'drupal/webform_civicrm:^6.2' - 🇪🇸Spain sluc23
hi @KarinG.. I don't understand your comment " I generally don't create tags for the Github repo." all tags are historically in that repo except for 6.2.5 (https://github.com/colemanw/webform_civicrm/tags).. that means you are not going to create any new tag in github from now on?
that will be weird because we do PRs in Github, and not in drupalcode, so not having tags and fully updated repo in github could lead to misunderstanding and wrong processes in the PRs.. am I missing something?
thanks!
- 🇨🇦Canada karing 🇨🇦
The github repo is fully updated - has all the commits - head is currently:
git log commit 6a466fe7daff8c374560344584922432052e9e01 (HEAD -> 6.x, origin/HEAD, origin/6.x) Merge: a76e094 fcfd561 Author: demeritcowboy Date: Mon Jan 8 14:25:30 2024 -0500 Merge pull request #936 from demeritcowboy/inv Deprecated settings
The git repo on drupal.org is alwas a bit behind - the code there corresponds to when I create the release on drupal.org - and I create the tag as part of that release process.
I honestly don't understand how those tags have been created on github - I don't recall pushing them! It's not part of my process to issue a release:
1. I pull a fresh copy from github:
rm -rf webform_civicrm git clone https://github.com/colemanw/webform_civicrm.git cd webform_civicrm git log
-> to check that the latest commit is there
2. Push to drupal -> this creates the -dev version on Drupal:
git push -u git@git.drupal.org:project/webform_civicrm.git
3. Create the tag (the release process on Drupal requires it) ->
git tag release_version git push -u git@git.drupal.org:project/webform_civicrm.git tag release_version
4. On the Drupal webform_civicrm project page -> Add new release -> select the new tag
When I create the next release I can add this to my process (right after I push the tag to the Drupal repo):
git push origin release_version
I just can't do this now because the github repo is already a bit ahead of the last release on drupal.org - or can I checkout on older commit and create / push the tag?
I don't know how to answer the question about how the tag used to get created or why it didn't get created, but I've pushed the 6.2.5 tag to github: https://github.com/colemanw/webform_civicrm/tags
- 🇪🇸Spain sluc23
thanks @demeritcowboy for tagging. I'm fine with any workflow you defined for webform_civicrm.. It just seems weird to use github repo for the community to collaborate with PRs, when the latests tags are not updated in that repo.. in my POV that could lead to some unwanted misunderstanding while working in these PRs.. but I was curious about the process.. thanks for responding I can close this!