- Issue created by @pfrenssen
- Merge request !8#3412399 Check that the file exists before attaching it. β (Merged) created by pfrenssen
- Status changed to Needs review
over 1 year ago 10:06pm 4 January 2024 - First commit to issue fork.
- πΊπΈUnited States zengenuity
This looks good. I think the check in the embedded images method is probably not needed. Embedded images are validated before this step, and there's already a check in there for file_exists(). But, I don't think it hurts to leave it in, since I suppose there could be another type of error reading the file, and we don't want a fatal error in that case.
The only thing I added is a couple of log error messages when we skip a file. Since we're silently failing in this case, I think it's a good idea to throw an error in the logs. I do get a PHP warning in the logs from file_get_contents(), but I'm not sure if everyone would get those depending on their PHP configuration.
Thanks for this. Merging now.
-
zengenuity β
committed 5e67813a on 1.0.x authored by
pfrenssen β
Issue #3412399 by pfrenssen, zengenuity: Exception when attaching a non-...
-
zengenuity β
committed 5e67813a on 1.0.x authored by
pfrenssen β
- Status changed to Fixed
over 1 year ago 2:16pm 5 January 2024 - πΊπΈUnited States zengenuity
I released version 1.0.1 with this fix.
Automatically closed - issue fixed for 2 weeks with no activity.