- Issue created by @andresgmh
- πΊπΈUnited States papagrande US West Coast
@andresgmh, thanks. This looks like a useful feature.
A few requests:
- If you are still updating your code, please assign yourself this task.
- Since Drupal is moving to Merge Requests on Gitlab, would you mind opening one instead of using patches? It's not a requirement, but it makes reviewing much easier.
- This module needs test coverage. Ideally, we would have tests to make sure this new feature doesn't cause regressions, but at a minimum we should test to confirm this feature is working.
- πΊπΈUnited States papagrande US West Coast
@andresgmh, thanks for the new patch, but a merge request will be easier to review and collaborate on. At a minimum, please provide an interdiff, https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... β , for your new patch. Thanks.