- Issue created by @zniki.ru
- last update
11 months ago 46 pass - last update
11 months ago 46 pass - Status changed to Needs review
11 months ago 8:45am 2 January 2024 - 🇷🇺Russia zniki.ru
Ready for review.
All fixes will be made in follow up tasks. - 🇷🇺Russia zniki.ru
Tests will be fixed in 📌 Tests should not unnecessarily declare a dependency on Classy theme RTBC .
- last update
11 months ago 46 pass - Status changed to Needs work
11 months ago 4:24pm 2 January 2024 - 🇨ðŸ‡Switzerland berdir Switzerland
phpunit jobs need 3 minutes because contrib by default runs them not parallel. Lets use concurrency/run-tests.sh, see https://git.drupalcode.org/project/webform/-/merge_requests/380/diffs#no... ( _PHPUNIT_CONCURRENT + _PHPUNIT_EXTRA).
opt in for next minor testing is also useful, we can use that instead with the "won" time.
- last update
11 months ago 46 pass - Status changed to Needs review
11 months ago 4:44pm 2 January 2024 - 🇷🇺Russia zniki.ru
@Berdir thanks for the feedback, I am not sure about _PHPUNIT_EXTRA is need for the flag module.
I made changes and it works much faster. - last update
11 months ago 46 pass -
Berdir →
committed 2ab20073 on 8.x-4.x authored by
Nikolay Shapovalov →
Issue #3411831: Adopt GitlabCi
-
Berdir →
committed 2ab20073 on 8.x-4.x authored by
Nikolay Shapovalov →
- Status changed to Fixed
11 months ago 10:50pm 3 January 2024 - 🇨ðŸ‡Switzerland berdir Switzerland
I guess the default behaviour was changed then. Tested locally and there are deprecations, then that seems fine to merge.
Automatically closed - issue fixed for 2 weeks with no activity.