Turbo: Re-enable Turbo cache once we can reliably detach before &lt;body&gt; is cached

Ambient.Impact → committed c41362db on 2.x

Upgraded Turbo to 8.0.0-beta.2:

This contains a lot of bug fixes and...

Status changed to Postponed 10 months ago

Comment 10 months ago →

🇨🇦Canada ambient.impact Toronto

Comment 7 months ago →

🇨🇦Canada ambient.impact Toronto

Updating the issue title and summary to reflect to the current state of the implementation. I've had a chance to work on the issue fork, and it seems it mostly works now if we detach behaviours on the turbo:before-cache event but there are still some remaining issues:

turbo:before-cache is not currently able to be delayed until a page has transitioned out, so if a behaviour detaching causes visible changes to the page, these will be briely seen before a transition out has begun; there are potential solutions to this:
1. TBD; coffee shop closing back later lolol
The core Navigation is even more broken due to lacking detach callbacks for most of its JavaScript; this is fixable by adding detach callbacks, but will take some time and untangling of its spaghetti JavaScript; see 🌱 Turbo: Tracking issue of core and contrib behaviours that need fixes to correctly detach and then attach Active

Comment 7 months ago →

🇨🇦Canada ambient.impact Toronto

Assigned to ambient.impact

Status changed to Active about 2 months ago

🇨🇦Canada ambient.impact Toronto

Spent the week on this because I discovered that preloading links into Turbo's cache can be a big performance boost in a lot of cases, and that requires caching to actually work. After a lot of trial and error and quite a lot of swearing, I got it to more or less working, but I'll have to test it over the following days to see if it's robust enough to merge.

🇨🇦Canada ambient.impact Toronto

Merge request !12Issue #3411449: Support Turbo cache → (Merged) created by ambient.impact

ambient.impact → committed 3289a752 on cache-and-lazy-preloader

Issues #3411449 & #3531642: Patch Turbo to identify preload + add event.

ambient.impact → committed 5a8f9e92 on cache-and-lazy-preloader

Issue #3411449: Prevent saving Drupal announce element to cache.

ambient.impact → committed 3289a752 on 2.x

Issues #3411449 & #3531642: Patch Turbo to identify preload + add event.

ambient.impact → committed 3289a752 on 2.0.x

Issues #3411449 & #3531642: Patch Turbo to identify preload + add event.

ambient.impact → committed 7eea8d00 on cache-and-lazy-preloader

Issue #3411449: Remove a few more classes on contextual detach.

ambient.impact → committed f2ab30d0 on cache-and-lazy-preloader

Issue #3411449: Update overrides/announce.js to detach before cache.

ambient.impact → committed 74398c97 on cache-and-lazy-preloader

Issue #3411449: Removed now fixed dropbutton cache workarounds.

ambient.impact → committed 73ba09ac on cache-and-lazy-preloader

Issue #3411449: Behaviours detached before caching; add custom triggers.

ambient.impact → committed 0eb70f70 on cache-and-lazy-preloader

Issue #3411449: Fix event tests for caching & add before-cache event.

ambient.impact → committed 0eb70f70 on 2.x

Issue #3411449: Fix event tests for caching & add before-cache event.

ambient.impact → committed f2ab30d0 on 2.x

Issue #3411449: Update overrides/announce.js to detach before cache.

ambient.impact → committed 74398c97 on 2.x

Issue #3411449: Removed now fixed dropbutton cache workarounds.

ambient.impact → committed 73ba09ac on 2.x

Issue #3411449: Behaviours detached before caching; add custom triggers.

ambient.impact → committed 7eea8d00 on 2.x

Issue #3411449: Remove a few more classes on contextual detach.

ambient.impact → committed 5a8f9e92 on 2.x

Issue #3411449: Prevent saving Drupal announce element to cache.

ambient.impact → committed b578df5e on 2.x

Issue #3411449: Added update hook for Turbo cache support changes.

ambient.impact → committed 273e7158 on 2.x

Issue #3411449 & #3399243: Navigation cache workarounds.

ambient.impact → committed fb2383d6 on 2.x

Issue #3411449: Split contextual and message cache fixes in own files.

ambient.impact → committed d69943b2 on 2.x

Issue #3411449: Added data-refreshless-temporary attribute.

ambient.impact → committed c607da26 on 2.x

Issue #3411449: Behaviours detached from non-preview cached snapshots:...

ambient.impact → committed 57d30564 on 2.x

Issue #3411449: Added cached snapshot  detection and event detail.

ambient.impact → committed 48a93fbc on 2.x

Issue #3411449: Remove contextual links from cached page.

ambient.impact → committed a61ee361 on 2.x

Issue #3411449: Messages now only removed from cache if after fallback.

ambient.impact → committed ed777ebc on 2.x

Issue #3411449: Behaviours & drupalSettings now support previews.

ambient.impact → committed eb401f1f on 2.x

Issue #3411449: Render events now triggered on previews:

Both '...

ambient.impact → committed e4be847e on 2.x

Issue #3411449: Before render event now exposes event.detail.isPreview.

ambient.impact → committed 2087c078 on 2.x

Issue #3411449: Before render event now runs on preview being shown.

ambient.impact → committed 206a64fa on 2.x

Issue #3411449: Added private property to track if preview render.

ambient.impact → committed ab4c42a7 on 2.x

Issue #3411449: Added 'refreshless:before-cache' event.

ambient.impact → committed 85a1e9c6 on 2.x

Issue #3411449: Don't save Drupal messages to Turbo cache.

ambient.impact → committed 422e3346 on 2.x

Issue #3411449: Behaviours now detached before Turbo caches page.

ambient.impact → committed 39b9497d on 2.x
```
Issue #3411449: Enable Turbo caching.
```

ambient.impact → committed 0eb70f70 on 2.0.x

Issue #3411449: Fix event tests for caching & add before-cache event.

ambient.impact → committed f2ab30d0 on 2.0.x

Issue #3411449: Update overrides/announce.js to detach before cache.

ambient.impact → committed 74398c97 on 2.0.x

Issue #3411449: Removed now fixed dropbutton cache workarounds.

ambient.impact → committed 73ba09ac on 2.0.x

Issue #3411449: Behaviours detached before caching; add custom triggers.

ambient.impact → committed 7eea8d00 on 2.0.x

Issue #3411449: Remove a few more classes on contextual detach.

ambient.impact → committed 5a8f9e92 on 2.0.x

Issue #3411449: Prevent saving Drupal announce element to cache.

ambient.impact → committed b578df5e on 2.0.x

Issue #3411449: Added update hook for Turbo cache support changes.

ambient.impact → committed 273e7158 on 2.0.x

Issue #3411449 & #3399243: Navigation cache workarounds.

ambient.impact → committed fb2383d6 on 2.0.x

Issue #3411449: Split contextual and message cache fixes in own files.

ambient.impact → committed d69943b2 on 2.0.x

Issue #3411449: Added data-refreshless-temporary attribute.

ambient.impact → committed c607da26 on 2.0.x

Issue #3411449: Behaviours detached from non-preview cached snapshots:...

ambient.impact → committed 57d30564 on 2.0.x

Issue #3411449: Added cached snapshot  detection and event detail.

ambient.impact → committed 48a93fbc on 2.0.x

Issue #3411449: Remove contextual links from cached page.

ambient.impact → committed a61ee361 on 2.0.x

Issue #3411449: Messages now only removed from cache if after fallback.

ambient.impact → committed ed777ebc on 2.0.x

Issue #3411449: Behaviours & drupalSettings now support previews.

ambient.impact → committed eb401f1f on 2.0.x

Issue #3411449: Render events now triggered on previews:

Both '...

ambient.impact → committed e4be847e on 2.0.x

Issue #3411449: Before render event now exposes event.detail.isPreview.

ambient.impact → committed 2087c078 on 2.0.x

Issue #3411449: Before render event now runs on preview being shown.

ambient.impact → committed 206a64fa on 2.0.x

Issue #3411449: Added private property to track if preview render.

ambient.impact → committed ab4c42a7 on 2.0.x

Issue #3411449: Added 'refreshless:before-cache' event.

ambient.impact → committed 85a1e9c6 on 2.0.x

Issue #3411449: Don't save Drupal messages to Turbo cache.

ambient.impact → committed 422e3346 on 2.0.x

Issue #3411449: Behaviours now detached before Turbo caches page.

ambient.impact → committed 39b9497d on 2.0.x
```
Issue #3411449: Enable Turbo caching.
```

🇨🇦Canada ambient.impact Toronto

This has finally been merged. Only lingering issue is to figure out if we can delay Turbo caching asynchronously like we can with rendering, but we can do that separately and it can be worked around in the meantime.

Comment 15 days ago →