Test-only job does not detect failures correctly

Note that the report shows them as errors: https://git.drupalcode.org/project/drupal/-/pipelines/65788/test_report

I think the reason for this is that the job is taking the exit code of the last command being run (https://stackoverflow.com/questions/70820135/gitlab-make-the-ci-cd-faile...), so we need to capture if there was any error during the script and then add an exit 1 in that case.

james.williams → made their first commit to this issue’s fork.

Thanks for your guidance @fjgarlin - hopefully !8466 is along the right lines?

The code changes look correct to me and hopefully that's all that's needed. Now we need to verify it. Two options:
- Bring the test files from that other job to this MR, run the test only, then remove those changes.
- Bring the changes from this MR to that other issue, run the test only, then remove the changes.

With that, I'd be happy to RTBC.

Thanks - I've done the second option; so let's see how https://git.drupalcode.org/issue/drupal-3454196/-/pipelines/203616 comes out for 🐛 Filter placeholders without arguments are not replaced when HTML corrector filter applied afterwards Needs review ...

Based on the code review I did before and this run https://git.drupalcode.org/issue/drupal-3454196/-/pipelines/203616 which verifies the fix in both the top level Test-only job and the per-version test-only job, I am marking this RTBC.

Committed and pushed 0ac3d2a036 to 11.x and 1c3d9629f4 to 11.0.x and 2d0757fde1 to 10.4.x and cdd8d3cc14 to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.