- Issue created by @lostcarpark
- Status changed to Needs review
12 months ago 1:44am 19 December 2023 - 🇮🇪Ireland lostcarpark
Please credit Dandolorion as logo designer.
- 🇬🇧United Kingdom dandolorion Oxford
jurgenhaas → credited Dandolorion → .
- 🇩🇪Germany jurgenhaas Gottmadingen
This is very nice, thanks for the great contribution.
I have 2 questions that I'd like to discuss before merging this:
- There seems to be a bit too much "whitespace" around the white symbol. Could that be balanced a bit?
- Is it possible to get the final logo as an SVG file as well? Yes, the repository requires the png but for other use cases we do have a collection of svg files as well and it would be sad to not have all of them for that matter.
- 🇮🇪Ireland lostcarpark
Hi @jurganhass,
@Dandolorion has created several other Commerce logos using the same shopping cart motif. If the whitespace were to change that would affect his other logos too, so I'd like his opinion on that.
The logo needs to be displayed a lot smaller in the project browser interface, so consideration needs to be given to how it looks at a reduced size.
I have made previews showing how various look the project browser interface. I'll try to do one for ECA Commerce later.
I agree 100% on ensuring the SVG versions of logos are preserved, and have start work on a dedicated repository → for those.
- 🇬🇧United Kingdom dandolorion Oxford
Hi @jurganhass,
I have used a consistent amount of white space for all icons in order to not have the icon appearing too tight when used. It is nice to give the icons area to 'breathe' rather than being too close to the edge. Saying that though, if the icon was going to be used at say <100px in size then I would suggest reducing the white space as you would do on something like a fsavicon. If an alt version is needed (as this was done for 512x512 visual perspective) then I am more than happy to supply a version.
@lostcarpark - I have sent over part1 of my icons converted to SVG. I have also sent icons that have not been used in case you need a fallback option or find another use for them
- 🇮🇪Ireland lostcarpark
Well, I feel dumb now. I was thinking "whitespace" was referring to the actual white parts. I'm getting over a cold.
I think Jurgen makes a very good point that this logo looks a little off-centre, visually. I think in some of the other logos, the element in the shopping cart has a lot more visual weight than the ECA logo, so having the shopping cart off centre makes sense. I agree refocusing it would make it look tidier.
- 🇬🇧United Kingdom dandolorion Oxford
Have updated. Moved right a few pixels. Anymore and it will look too far to the left due to the white space on the left below the cart handle.
- 🇮🇪Ireland lostcarpark
I have replaced the logo in the MR with the version from #11.
- Status changed to Fixed
12 months ago 10:04pm 20 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.