PackageManagerUninstallValidator needs to use dependency injection to pass on 11.x

Issue created by @tedbow
Merge request !996Resolve #3409519 → (Merged) created by tedbow
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
710 pass, 14 fail
Status changed to Needs review 10 months ago4:14pm 18 December 2023
Comment 10 months ago →
🇺🇸United States tedbow Ithaca, NY, USA
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
CI aborted
Status changed to Needs work 10 months ago4:24pm 18 December 2023
Comment 10 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
CI aborted
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
783 pass
Status changed to RTBC 10 months ago4:40pm 18 December 2023
Comment 10 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Looks great!

This matches the way Drupal core does things since 10.1 (constructor with many arguments spread across many lines, use private readonly when appropriate).

All unit tests passed, 90% of kernel tests have, so assuming this hits 100% green test results, I think this is ready 😊

tedbow → committed de9413f4 on 3.0.x

Issue #3409519: PackageManagerUninstallValidator needs to use dependency...

Status changed to Fixed 9 months ago7:07pm 19 December 2023
Comment 9 months ago →
🇺🇸United States tedbow Ithaca, NY, USA
Comment 9 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Status changed to Fixed 9 months ago11:29am 3 January 2024
Comment 9 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Merge Requests