PackageManagerUninstallValidator needs to use dependency injection to pass on 11.x

Issue created by @tedbow
Merge request !996Resolve #3409519 → (Merged) created by tedbow
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
710 pass, 14 fail
Status changed to Needs review over 1 year ago4:14pm 18 December 2023
Comment over 1 year ago →
🇺🇸United States tedbow Ithaca, NY, USA
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
CI aborted
Status changed to Needs work over 1 year ago4:24pm 18 December 2023
Comment over 1 year ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
CI aborted
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
783 pass
Status changed to RTBC over 1 year ago4:40pm 18 December 2023
Comment over 1 year ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Looks great!

This matches the way Drupal core does things since 10.1 (constructor with many arguments spread across many lines, use private readonly when appropriate).

All unit tests passed, 90% of kernel tests have, so assuming this hits 100% green test results, I think this is ready 😊

tedbow → committed de9413f4 on 3.0.x

Issue #3409519: PackageManagerUninstallValidator needs to use dependency...

Status changed to Fixed over 1 year ago7:07pm 19 December 2023
Comment over 1 year ago →
🇺🇸United States tedbow Ithaca, NY, USA
Comment over 1 year ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Status changed to Fixed over 1 year ago11:29am 3 January 2024
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.
Pipeline finished with Failed
about 1 month ago
Total: 706s
#492386
Pipeline finished with Failed
21 days ago
Total: 834s
#500601
Pipeline finished with Failed
20 days ago
Total: 658s
#501057
Pipeline finished with Failed
20 days ago
Total: 405s
#501210
Pipeline finished with Failed
20 days ago
Total: 624s
#501212
Pipeline finished with Success
20 days ago
Total: 819s
#501219
Pipeline finished with Failed
20 days ago
Total: 1233s
#501781
Pipeline finished with Failed
20 days ago
Total: 701s
#501852
Pipeline finished with Failed
20 days ago
Total: 619s
#501899
Pipeline finished with Success
20 days ago
Total: 663s
#501911
Pipeline finished with Success
19 days ago
Total: 1093s
#502028
Pipeline finished with Canceled
19 days ago
Total: 272s
#502198
Pipeline finished with Success
19 days ago
Total: 725s
#502210
Pipeline finished with Success
19 days ago
Total: 970s
#502259

Merge Requests