- Issue created by @Leo Pitt
- 🇬🇧United Kingdom Leo Pitt
Patch attached:
- Add a scrub_fields field to module settings form.
- Pass scrub_fields to Rollbar init() method.
- Minor refactoring init() method for efficiency.
- Status changed to Needs review
about 1 year ago 11:47am 18 December 2023 - Status changed to Needs work
about 1 year ago 4:25pm 18 December 2023 - 🇬🇧United Kingdom intrafusion Edinburgh, UK
This is unnecessarily complicated, the following changes can be made:
$form['scrub_fields'] = [ '#type' => 'textarea', '#title' => $this->t('Scrub fields'), '#default_value' => implode("\n", $config->get('scrub_fields')), '#description' => $this->t('Field names to scrub out of the entire payload. Enter one field name per line. Values will be replaced with asterisks.'), ];
->set('scrub_fields', preg_split("(\r\n?|\n)", $form_state->getValue('scrub_fields')))
// Populate basic configuration. $configuration = [ 'access_token' => $token, 'environment' => $environment, 'scrub_fields' => $this->config->get('scrub_fields') ?? [], ];
Also a merge request is much easier for a maintainer to review and accept
- Status changed to Needs review
about 1 year ago 10:33am 19 December 2023 -
Leo Pitt →
authored 26aa5db1 on 2.1.x
Issue #3409446 by Leo Pitt: Allow configuration of "scrub_fields"
-
Leo Pitt →
authored 26aa5db1 on 2.1.x
- Status changed to Fixed
about 1 year ago 11:05am 21 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.