- Issue created by @ergonlogic
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 10:55pm 15 December 2023 - π¨π¦Canada ergonlogic MontrΓ©al, QuΓ©bec π¨π¦
I pushed a fix to the MR branch.
- Merge request !396Issue #3409166: Add missing 'label' for conditions in config schema. β (Open) created by ergonlogic
- last update
about 1 year ago 276 pass - Status changed to Needs work
12 months ago 1:24pm 22 December 2023 - π©πͺGermany jurgenhaas Gottmadingen
This is not a bug, we haven't had labels on conditions since the very beginning, but I can see that it would be nice to have them as well like for events and actions.
However, just adding a schema item is not sufficient here. This is triggered by the request coming from eca_cm, but that modeller is not using any of the APIs that ECA provides for modellers to read and write models. As we do not recommend the usage of the classic modeller, we can only add new features into ECA that come through the proper API.
In the case of conditions labels, this process needs to start by looking into
\Drupal\eca\Entity\Eca::addCondition
which modellers are supposed to be calling when they want to add a condition to a model while saving it. Currently, this method doesn't accept a label, which should be changed, as well as all downstream methods as well.While being on it, we should then also enhance the debugging/logging calls, so that they also take the condition labels into account.
Re-basing this on the 2.0.x branch, since this is where new feature will be added.
- last update
12 months ago 297 pass - last update
12 months ago 297 pass - π©πͺGermany jurgenhaas Gottmadingen
Not a beta blocker, marked that by mistake.
- π©πͺGermany jurgenhaas Gottmadingen
@ergonlogic are you still up for this challenge?