Add missing 'label' for conditions in config schema

Created on 15 December 2023, over 1 year ago

Problem/Motivation

Both events and actions support custom labels. However, conditions currently do not.

See Allow Conditions to have custom labels Needs review

Proposed resolution

Add a 'label' entry for conditions in config schema.

🐛 Bug report
Status

Active

Version

1.1

Component

Code

Created by

🇨🇦Canada ergonlogic Montréal, Québec 🇨🇦

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @ergonlogic
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • 🇨🇦Canada ergonlogic Montréal, Québec 🇨🇦

    I pushed a fix to the MR branch.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    276 pass
  • Status changed to Needs work over 1 year ago
  • 🇩🇪Germany jurgenhaas Gottmadingen

    This is not a bug, we haven't had labels on conditions since the very beginning, but I can see that it would be nice to have them as well like for events and actions.

    However, just adding a schema item is not sufficient here. This is triggered by the request coming from eca_cm, but that modeller is not using any of the APIs that ECA provides for modellers to read and write models. As we do not recommend the usage of the classic modeller, we can only add new features into ECA that come through the proper API.

    In the case of conditions labels, this process needs to start by looking into \Drupal\eca\Entity\Eca::addCondition which modellers are supposed to be calling when they want to add a condition to a model while saving it. Currently, this method doesn't accept a label, which should be changed, as well as all downstream methods as well.

    While being on it, we should then also enhance the debugging/logging calls, so that they also take the condition labels into account.

    Re-basing this on the 2.0.x branch, since this is where new feature will be added.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    297 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    297 pass
  • 🇩🇪Germany jurgenhaas Gottmadingen
  • Pipeline finished with Success
    about 1 year ago
    Total: 280s
    #124648
  • 🇩🇪Germany jurgenhaas Gottmadingen
  • 🇩🇪Germany jurgenhaas Gottmadingen

    Not a beta blocker, marked that by mistake.

  • 🇩🇪Germany jurgenhaas Gottmadingen
  • Pipeline finished with Success
    10 months ago
    Total: 478s
    #197216
  • 🇩🇪Germany jurgenhaas Gottmadingen

    @ergonlogic are you still up for this challenge?

  • Pipeline finished with Failed
    5 months ago
    Total: 580s
    #331447
  • Pipeline finished with Failed
    5 months ago
    Total: 535s
    #332202
  • Pipeline finished with Failed
    5 months ago
    Total: 515s
    #333175
  • Pipeline finished with Success
    5 months ago
    Total: 543s
    #337651
  • Pipeline finished with Failed
    5 months ago
    Total: 615s
    #337747
  • Pipeline finished with Failed
    5 months ago
    Total: 541s
    #340116
  • Pipeline finished with Success
    5 months ago
    Total: 546s
    #340183
  • Pipeline finished with Success
    5 months ago
    Total: 516s
    #342438
  • Pipeline finished with Failed
    4 months ago
    Total: 742s
    #347133
  • Pipeline finished with Canceled
    4 months ago
    Total: 627s
    #347152
  • Pipeline finished with Success
    4 months ago
    Total: 582s
    #347166
  • Pipeline finished with Success
    2 months ago
    Total: 252s
    #402473
  • Pipeline finished with Failed
    2 months ago
    Total: 1001s
    #404057
  • Pipeline finished with Failed
    2 months ago
    Total: 997s
    #404190
  • Pipeline finished with Failed
    2 months ago
    Total: 904s
    #404894
  • Assigned to jurgenhaas
  • 🇩🇪Germany jurgenhaas Gottmadingen

    I'll get into this as it is required if we only deal with eca.eca.* config entities and throw away the eca.model.* config entities.

  • Pipeline finished with Failed
    about 2 months ago
    Total: 328s
    #414082
  • Pipeline finished with Failed
    about 2 months ago
    Total: 952s
    #414083
  • Pipeline finished with Success
    about 2 months ago
    Total: 971s
    #414693
  • Pipeline finished with Success
    about 2 months ago
    Total: 1068s
    #414717
  • Pipeline finished with Success
    about 2 months ago
    Total: 1184s
    #415848
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1169s
    #420998
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1092s
    #421297
  • Pipeline finished with Success
    about 2 months ago
    Total: 1313s
    #421460
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1161s
    #422078
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1169s
    #422114
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1259s
    #422231
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1255s
    #422341
  • Pipeline finished with Canceled
    about 2 months ago
    Total: 103s
    #423268
  • Pipeline finished with Success
    about 2 months ago
    Total: 1333s
    #423270
Production build 0.71.5 2024